-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency cleanup for big simulation plugin #45607
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45607/41100 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @antoniovagnerini, @civanch, @cmsbuild, @consuegs, @francescobrivio, @makortel, @mdhildreth, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @smuzaffar, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
@bsunanda , FYI , for me this PR is fine. |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+Upgrade |
+1 |
+core |
@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this change? This change practically do not change any thing. It only avoids compilation of @cms-sw/dqm-l2 , this Pr only removes the unused |
+1 |
@cms-sw/dqm-l2 , can you please review this? for DQM the change is really trivial i.e. remove unnecessary geant4 dependency |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR proposes to
CondFormats/EcalObjects CondFormats/HcalObjects
: Do not build*GPU.cc
CondFormats/HGCalObjects: Do not build
HeterogeneousHGCalHEFCellPositionsConditions.cc`geant4core
dependency fromValidation/HGCalValidation
Validation/HGCalValidation
(which now does not depend ongeant4
) fromSimulation
big pluginThese changes should allow to build buig Simulation plugin for Riscv 64